Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

This review has turned out to be more epic than I initially thought! I'm submitting a partial review of what I have so far.

Also, I noticed that these two files need to be updated to remove standalone: true and standalone: false:

• src/SIL.XForge.Scripture/ClientApp/src/app/shared/json-viewer/json-viewer.component.ts
• src/SIL.XForge.Scripture/ClientApp/src/app/shared/json-viewer/json-viewer.component.spec.ts

@pmachapman reviewed 203 of 305 files at r1, all commit messages.
Reviewable status: 203 of 305 files reviewed, 4 unresolved discussions

src/SIL.XForge.Scripture/ClientApp/src/app/my-projects/my-projects.stories.ts line 195 at r1 (raw file):

      imports: [
        UICommonModule,
        SharedModule.forRoot(),

I think that the change to the chromatic tests is from this removal. (I don't think we should add provideUICommon() - I just wanted to flag what I think the possible cause is)

Code quote:

        UICommonModule,
        SharedModule.forRoot(),

src/SIL.XForge.Scripture/ClientApp/src/app/serval-administration/job-events-dialog.component.ts line 39 at r1 (raw file):

  imports: [MatDialogTitle, MatDialogContent, MatDialogActions, MatDialogClose, MatIcon, JsonViewerComponent]
})
export class JobEventsDialogComponent {

RE: Your merge conflict, this class is now JobDetailsDialogComponent (job-details-dialog.component.ts)

Code quote:

export class JobEventsDialogComponent {

src/SIL.XForge.Scripture/ClientApp/src/app/event-metrics/event-metric-dialog.component.html line 2 at r1 (raw file):

<ng-container *transloco="let t; read: 'event_metric_dialog'">
  <div [dir]="i18n.direction">

I'm guessing this was changed because <mat-dialog> is not a valid tag?

I did a quick search and this tag is still being used in:

• src/SIL.XForge.Scripture/ClientApp/src/app/checking/import-questions-dialog/import-questions-confirmation-dialog/import-questions-confirmation-dialog.component.html
• src/SIL.XForge.Scripture/ClientApp/src/app/settings/delete-project-dialog/delete-project-dialog.component.html

Code quote:

<div [dir]="i18n.direction">

src/SIL.XForge.Scripture/ClientApp/.storybook/preview.ts line 13 at r1 (raw file):

import docJson from '../documentation.json';
import { provideSFTabs } from '../src/app/shared/sf-tab-group';
import { provideUICommon } from '../src/xforge-common/ui-common-providers';

NIT: This should be:

import { provideUICommon } from 'xforge-common/ui-common-providers';

Code quote:

import { provideUICommon } from '../src/xforge-common/ui-common-providers';

src/SIL.XForge.Scripture/ClientApp/src/main.ts line 10 at r1 (raw file):

} from '@angular/core';

import { ExceptionHandlingService } from 'xforge-common/exception-handling.service';

NIT: If the new lines are removed from above and below this line, the imports will sort correctly.

Suggestion:

import { ExceptionHandlingService } from 'xforge-common/exception-handling.service';

Reviewable status: 203 of 305 files reviewed, 2 unresolved discussions (waiting on @pmachapman)

src/SIL.XForge.Scripture/ClientApp/.storybook/preview.ts line 13 at r1 (raw file):

Done.

src/SIL.XForge.Scripture/ClientApp/src/main.ts line 10 at r1 (raw file):

Done.

src/SIL.XForge.Scripture/ClientApp/src/app/event-metrics/event-metric-dialog.component.html line 2 at r1 (raw file):

Good catch, thanks!

src/SIL.XForge.Scripture/ClientApp/src/app/my-projects/my-projects.stories.ts line 195 at r1 (raw file):

Yeah, maybe it is related to removal of UICommonModule, although provideUICommon() is now being applied to all stories via preview.ts.

src/SIL.XForge.Scripture/ClientApp/src/app/serval-administration/job-events-dialog.component.ts line 39 at r1 (raw file):

Thanks for the heads up!

Just a couple more nits!

@pmachapman reviewed 102 of 305 files at r1, 10 of 10 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @siltomato)

src/SIL.XForge.Scripture/ClientApp/src/app/translate/training-progress/training-progress.component.ts line 11 at r2 (raw file):

import { quietTakeUntilDestroyed } from 'xforge-common/util/rxjs-util';

import { MatIconButton } from '@angular/material/button';

NIT: Are you able to remove the line break here to help sorting?

Code quote:

import { quietTakeUntilDestroyed } from 'xforge-common/util/rxjs-util';

import { MatIconButton } from '@angular/material/button';

src/SIL.XForge.Scripture/ClientApp/src/app/translate/editor/tabs/editor-tab-add-resource-dialog/editor-tab-add-resource-dialog.component.spec.ts line 5 at r2 (raw file):

import { provideAnimations } from '@angular/platform-browser/animations';

import { SFProject } from 'realtime-server/lib/esm/scriptureforge/models/sf-project';

NIT: Are you able to remove the line break here to help sorting?

Code quote:

import { provideAnimations } from '@angular/platform-browser/animations';

import { SFProject } from 'realtime-server/lib/esm/scriptureforge/models/sf-project';

Reviewable status: 291 of 310 files reviewed, all discussions resolved (waiting on @pmachapman)

src/SIL.XForge.Scripture/ClientApp/src/app/translate/editor/tabs/editor-tab-add-resource-dialog/editor-tab-add-resource-dialog.component.spec.ts line 5 at r2 (raw file):

Done.

src/SIL.XForge.Scripture/ClientApp/src/app/translate/training-progress/training-progress.component.ts line 11 at r2 (raw file):

Done.

@pmachapman reviewed 21 of 21 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @siltomato)